replace extra_filename with strict version hash in metrics file names #138950
+5
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
If I compile once, make a small change to the source code and compile again with the same options, is it fine to overwrite the old metrics file or not. If it is fine, you can use the stable crate id. If it must not be overwritten, using the crate hash like you do here is the correct solution. |
bjorn3
reviewed
Mar 25, 2025
| metrics_file_name.push(metrics_file_stem); | ||
| metrics_path.pop(); | ||
| metrics_path.push(metrics_file_name); | ||
| let crate_id = rustc_span::def_id::LOCAL_CRATE; |
There was a problem hiding this comment.
Maybe add use rustc_span::def_if::LOCAL_CRATE at the top of this file and use LOCAL_CRATE below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve the potential issue of overwriting metrics from the same crate when compiled with different features or flags.
r? @estebank