Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to JDK11 for travis builds #13

Closed
wants to merge 1 commit into from
Closed

Bump to JDK11 for travis builds #13

wants to merge 1 commit into from

Conversation

Khalian
Copy link

@Khalian Khalian commented Sep 11, 2020

Update on JDK version for builds since 11 is the new LTS for OpenJDK.

Update on JDK version for builds since 11 is the new LTS for OpenJDK.
@SethTisue
Copy link
Member

adding 11 seems good, but I wouldn't suggest removing 8

@SethTisue
Copy link
Member

@Khalian ping... interested in responding to the review feedback?

@Khalian
Copy link
Author

Khalian commented Jan 16, 2021

Why keep 8 for travis?

@SethTisue
Copy link
Member

SethTisue commented Jan 16, 2021

In general, Scala projects build and test and publish on JDK 8. JDK 8 is the baseline version that Scala 2.12+ supports, and so almost everyone uses 8 in their CI to make sure that everything works on 8. Many projects also include 11 and/or 15 in their CIs, but as alternate testing paths, rather than as the main path.

However: this repo in particular is a Giter8 template, so arguably that alters things. The usual reason to publish on 8 is to ensure that the code doesn't accidentally include calls to JDK 11+ only API. But Giter8 templates aren't published as binaries, but as source.

Regardless: there is possibly some value in having CI ensure that everything works on 8. An example of a failure mode we might catch is that sometimes an upstream dependency accidentally publishes a binary that requires 11.

The reverse failure mode is less plausible, since Java stuff is almost always backward compatible, but it is possible for something to work on 8 but fail on 11, for example if the build passes an -XX flag that Oracle removed from 11, or if something runs afoul of the module system somehow, I suppose.

Summary:

  • For a Giter8 template, it probably doesn't matter which JDK we use.
  • Regardless, if we had to choose only one JDK to test on, I would choose 8.
  • Regardless, why not test on both 8 and 11?

@Khalian Khalian closed this Jan 23, 2021
@Khalian
Copy link
Author

Khalian commented Jan 23, 2021

Understood. Dropping the PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants