Update fields related to latestRoundData
#2479
Conversation
codersjj
requested review from
gfletcher-cll,
aelmanaa and
khadni
as code owners
|
@codersjj is attempting to deploy a commit to the Chainlink Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
@khadni please verify |
| @@ -4,7 +4,7 @@ | |||
| "tabWidth": 2, | |||
| "trailingComma": "es5", | |||
| "printWidth": 120, | |||
| "plugins": ["prettier-plugin-astro"], | |||
| "plugins": ["prettier-plugin-astro", "prettier-plugin-solidity"], | |||
There was a problem hiding this comment.
@codersjj Thank you for your suggestion! However, the repo already has proper Solidity formatting support through prettier-plugin-solidity which is installed as a dev dependency. The plugin is already being used through our existing config:
-
Solidity-specific formatting rules defined in the
.prettierrcoverrides section -
Our VSCode settings are configured to use Prettier for Solidity formatting
"solidity.formatter": "prettier"- The plugin is properly integrated into our dev workflow (in the test config and linting setup).
Adding the plugin to the plugins array here would be redundant.
Could you please remove this change from your PR so I can merge it?
There was a problem hiding this comment.
@codersjj Thank you for your suggestion! However, the repo already has proper Solidity formatting support through
prettier-plugin-soliditywhich is installed as a dev dependency. The plugin is already being used through our existing config:
- Solidity-specific formatting rules defined in the
.prettierrcoverrides section- Our VSCode settings are configured to use Prettier for Solidity formatting
"solidity.formatter": "prettier"
- The plugin is properly integrated into our dev workflow (in the test config and linting setup).
Adding the plugin to the plugins array here would be redundant.
Could you please remove this change from your PR so I can merge it?
I added this configuration because I encountered errors with the prettier --write command during my commit process. While the project already has Solidity formatting support, this specific addition helped me resolve formatting issues I was experiencing.
If I remove this change, how should I resolve this issue? 😕
| /* uint80 roundId */, | ||
| int256 answer, | ||
| /*uint256 startedAt*/, | ||
| /*uint256 updatedAt*/, |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
IMPORTANT: Please do not create a Pull Request without creating an issue first.Any change needs to be discussed before proceeding.
Closing issues
closes #2478
Description
Update fields related to
latestRoundData.Changes