Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add @stdlib/iter/cartesian-power #1336

Open
3 tasks done
kgryte opened this issue Feb 21, 2024 · 5 comments · May be fixed by #2534
Open
3 tasks done

[RFC]: add @stdlib/iter/cartesian-power #1336

kgryte opened this issue Feb 21, 2024 · 5 comments · May be fixed by #2534
Assignees
@TheNourhan
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 21, 2024

Description

This RFC proposes adding the package @stdlib/iter/cartesian-power.

This package would be the iterator equivalent of @stdlib/array/cartesian-power.

function iterCartesianPower( x, n ) { ... }

where x is an input array-like object and n is an integer power.

Package: @stdlib/iter/cartesian-power
Alias: iterCartesianPower

Related Issues

Related issues #1334.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 21, 2024
@TheNourhan
Copy link
Contributor

I want to solve this problem do I create a cartesian-power folder and put my code inside it?

@kgryte
Copy link
Member Author

kgryte commented Feb 21, 2024 •
edited
Loading

@TheNourhan Thanks for reaching out. To get started, you'll want to follow the Download, Installation, and Verification steps outlined in the development guide: https://github.com/stdlib-js/stdlib/blob/develop/docs/development.md#download

Once you've setup your local environment, I suggest copying, e.g., the contents of an existing package (e.g., @stdlib/iter/linspace) to a cartesian-power folder in the iter directory, updating the copyright years to 2024, and then modifying the package contents according to the needs specified in the RFC above. Once you've done that, you should open a PR and we can discuss more there.

@gunjjoshi
Copy link
Member

I would love to work on this, so should I make the PR directly, or should I be assigned to this issue first ?

@kgryte
Copy link
Member Author

kgryte commented Feb 22, 2024

@gunjjoshi You may want to find another issue, unless @TheNourhan is not planning on working on this.

@TheNourhan
Copy link
Contributor

I'm working on it, it's almost done.

@TheNourhan TheNourhan mentioned this issue Feb 22, 2024
Closed
1 task
@kgryte kgryte added Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. priority: Low Low priority concern or feature request. labels Feb 23, 2024
@TheNourhan TheNourhan linked a pull request Jul 8, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheNourhan TheNourhan

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
3 participants
@kgryte @gunjjoshi @TheNourhan