-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC]: add math/base/special/sind
#32
Comments
Are the degree modules one-liners that multiply by pi / 180 and call out to other functions? |
Not necessarily, as one can perform argument reduction for better accuracy. See Julia, for example. |
Based on the reference implementation, implementing this package depends on kernel cc/ @Planeshifter |
I see the above comments on May 6. Is anyone working on this? or can I try ? |
No one was yet to work on this as we have yet to implement kernel |
The kernel |
@Planeshifter Looks like we will also need kernel cosine, as well. |
If you want to start working on this, @vinothdinakar, you could require the internal package functions directly for now, as in var kernelSin = require( '@stdlib/math/base/special/sin/lib/kernel_sin.js' ); We can then replace the require statements once the standalone packages are up. I will have the kernel packages done by the end of the week, at latest. |
@Planeshifter Awesome! @vinothdinakar Feel free to submit a PR once you have a working prototype. |
Ok Thanks |
@vinothdinakar Just to give you an update, @Planeshifter managed to implement the various kernel packages: @stdlib/math/base/special/kernel-sin So, if you are still interested and/or already working on it, feel free to use the above packages. :) Updated reference implementation: https://github.com/JuliaLang/julia/blob/9ef2af9db620644253941e080b5b4986ad0d6091/base/special/trig.jl#L1017 |
Checklist
RFC:
.Description
Compute the sine of
x
wherex
is in degrees.Package:
@stdlib/math/base/special/sind
Alias:
base.sind
For a reference implementation, see Julia.
Related Issues
No.
Questions
No.
Other
No.
The text was updated successfully, but these errors were encountered: