Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Add slash command for posting a PR-specific command comment #9

Open
Planeshifter opened this issue Feb 13, 2025 · 2 comments · May be fixed by stdlib-js/stdlib#5640
Open

[RFC]: Add slash command for posting a PR-specific command comment #9

Planeshifter opened this issue Feb 13, 2025 · 2 comments · May be fixed by stdlib-js/stdlib#5640
Assignees
Labels
difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. estimate: 4-8hrs Task which should take between 4 to 8 hours. Feature Task to add a new feature. ❌ No AI Not allowed to use AI.

Comments

@Planeshifter
Copy link
Member

Planeshifter commented Feb 13, 2025

This RFC proposes adding a new slash command /stdlib commands-comment that automatically generates and posts PR-specific build and test commands as a comment from the @stdlib-bot. This will help streamline the PR review process by providing contributors with the exact commands needed to build, test, and benchmark their changes.

The slash command should:

  • Automatically detect the package path from the PR's changed files

  • Generate the appropriate make commands for:

    • Building native add-ons
    • Running C examples
    • Running C benchmarks
    • Running JavaScript examples
    • Running JavaScript benchmarks
    • Running tests

In the new GitHub actions workflow for this slash command, we will need to Implement logic to:

  • Identify changed package paths
  • Generate appropriate command strings based on package path
  • Format commands in markdown
  • Post formatted comment via GitHub API

One open question is how to handle the case when multiple packages are modified in one PR.

Time estimate without AI: 4h.
Time estimate with AI: 3h.

@kgryte kgryte changed the title [FEATURE]: Slash Command for PR-Specific Command Comment [RFC]: Add slash command for posting a PR-specific command comment Feb 14, 2025
@kgryte kgryte added difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Task to add a new feature. estimate: 4-8hrs Task which should take between 4 to 8 hours. labels Feb 14, 2025
@naterush naterush added ❌ No AI Not allowed to use AI. 🤖 AI Allowed to use AI. and removed ❌ No AI Not allowed to use AI. labels Feb 17, 2025
@naterush naterush added ❌ No AI Not allowed to use AI. and removed 🤖 AI Allowed to use AI. ❌ No AI Not allowed to use AI. labels Feb 25, 2025
@Planeshifter
Copy link
Member Author

Notes: Scoped it down a little to not handle case of multiple packages touched in a single PR. Work went decently smoothly; it was a great help that we have already done most of the operations needed for it to work somewhere else in the codebase, so I could often orient myself on what's already there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. estimate: 4-8hrs Task which should take between 4 to 8 hours. Feature Task to add a new feature. ❌ No AI Not allowed to use AI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants