Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add @stdlib/string/base/replace-after #812

Closed
3 tasks done
kgryte opened this issue Feb 1, 2023 · 1 comment · Fixed by #1363 · May be fixed by #922
Closed
3 tasks done

[RFC]: Add @stdlib/string/base/replace-after #812

kgryte opened this issue Feb 1, 2023 · 1 comment · Fixed by #1363 · May be fixed by #922
Assignees
@AuenKr
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 1, 2023

Description

This RFC proposes adding a utility to replace the substring after the first occurrence of a specified search string.

Similar to other base string APIs, the package should assume valid inputs.

Logic should be similar to @stdlib/string/substring-after.

Package: @stdlib/string/base/replace-after
Alias: replaceAfter

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 1, 2023
This was referenced Feb 24, 2023
Closed
Open
@AuenKr
Copy link
Contributor

AuenKr commented Feb 23, 2024 •
edited
Loading

Hey @kgryte, Can i work on this issue?

@AuenKr AuenKr mentioned this issue Feb 24, 2024
Merged
1 task
@kgryte kgryte mentioned this issue Feb 24, 2024
Closed
3 tasks
@kgryte kgryte added priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 24, 2024
kgryte added a commit that referenced this issue Feb 25, 2024
@AuenKr @kgryte
feat: add string/base/replace-after

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
04ee89f 
Closes: #812
PR-URL: 	#1363
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Golden <103646877+AuenKr@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AuenKr AuenKr

Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
2 participants
@kgryte @AuenKr