Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add iter/cartesian-square #1371

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add iter/cartesian-square #1371

wants to merge 4 commits into from

Conversation

vinayak-00017
Copy link

@vinayak-00017 vinayak-00017 commented Feb 24, 2024 •
edited by kgryte
Loading

Resolves #1334 .

Description

What is the purpose of this pull request?
implements the package @stdlib/iter/cartesian-square.

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Feb 24, 2024
@kgryte kgryte changed the title feat: added iterCartesianSquare feat: add iter/cartesian-square Feb 24, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 25, 2024
@vinayak-00017
fix(lib/node_modules/@stdlib/iter/cartesian-square): resolved issues …
e0c038c 
…with the package

Signed-off-by: vinayak <fobo401@gmail.com>
@vinayak-00017
fix(lib/node_modules/@stdlib/iter/cartesian-square): resolved issues …
d44610d 
…with package

Signed-off-by: vinayak <fobo401@gmail.com>
@vinayak-00017
Copy link
Author

I have made the changes you mentioned. Thanks for the review.

Planeshifter
Planeshifter requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests currently won't run in environments lacking Symbol.iterator support. See the tests for other iterator packages such as https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/iter/head/test/test.js for how to ensure that tests can run in older environments lacking Symbols. This is currently blocking merging this PR.

@kgryte
Copy link
Member

kgryte commented Jun 11, 2024

@vinayak-00017 Are you still interested in working on this PR?

@vinayak-00017
Copy link
Author

@vinayak-00017 Are you still interested in working on this PR?

I apologise, I might not be able to complete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte

@stdlib-bot stdlib-bot

@Planeshifter Planeshifter

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/iter/cartesian-square
4 participants
@vinayak-00017 @kgryte @Planeshifter @stdlib-bot