Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add string/base/distances/hamming-grapheme-clusters #1684

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: add string/base/distances/hamming-grapheme-clusters #1684

wants to merge 2 commits into from

Conversation

mayankkamboj47
Copy link

Description

What is the purpose of this pull request?

This pull request:
Adds string/base/distances/hamming-grapheme-clusters for computing hamming distances between strings, by treating grapheme clusters, as opposed to Unicode code points, as the basic unit at which the difference is measured.

Related Issues

Does this pull request have any related issues?

Yes #836

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Mar 4, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 4, 2024
@kgryte kgryte changed the title feat: add string/base/distances/hamming-grapheme-clusters feat: add string/base/distances/hamming-grapheme-clusters Mar 4, 2024
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 17, 2024
@kgryte kgryte self-requested a review March 17, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot

@kgryte kgryte

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayankkamboj47 @kgryte @stdlib-bot