Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for computing the derivative of cardinal sine (cosc) #257

Open
wants to merge 146 commits into
base: develop
Choose a base branch
from

Conversation

Rinbo
Copy link

@Rinbo Rinbo commented Mar 14, 2019

Resolves #224.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines, including the relevant style guides.
  • Read and understand the Code of Conduct.
  • Read and understood the licensing terms.
  • Searched for existing issues and pull requests before submitting this pull request.
  • Filed an issue (or an issue already existed) prior to submitting this pull request.
  • Rebased onto latest develop.
  • Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?
No
This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The Julia implementation of cosc(x) went bananas for approximately every tenth value of x in the tiny negative and tiny positive test range To make the tests pass I decided to just skip these fixture values (often in the range of 1e+300 when in fact they should be ~0).


@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Mar 15, 2019
@kgryte
Copy link
Member

kgryte commented Mar 15, 2019

@Rinbo Thanks for working on this! Will review later this evening!

@kgryte kgryte self-requested a review March 15, 2019 01:26
@kgryte kgryte changed the title RFC: add support for computing the derivative of cardinal sine (cosc) Add support for computing the derivative of cardinal sine (cosc) Mar 22, 2019
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add support for computing the derivative of cardinal sine (cosc)
3 participants