-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for computing the derivative of cardinal sine (cosc) #257
Open
Rinbo
wants to merge
146
commits into
stdlib-js:develop
Choose a base branch
from
Rinbo:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Rinbo Thanks for working on this! Will review later this evening! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Issue or pull request for adding a new feature.
Math
Issue or pull request specific to math functionality.
Potential Duplicate
There might be another pull request resolving the same issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #224.
Checklist
develop
.develop
branch.Description
This pull request:
[RFC]: add support for computing the derivative of cardinal sine (cosc) #224
Related Issues
Questions
No.
Other
The Julia implementation of cosc(x) went bananas for approximately every tenth value of x in the tiny negative and tiny positive test range To make the tests pass I decided to just skip these fixture values (often in the range of 1e+300 when in fact they should be ~0).
@stdlib-js/reviewers