Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/wrapf #3055

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

feat: add math/base/special/wrapf #3055

wants to merge 16 commits into from

Conversation

gururaj1512
Copy link
Contributor

@gururaj1512 gururaj1512 commented Nov 2, 2024 •
edited by gunjjoshi
Loading

Resolves a part of #649

Description

What is the purpose of this pull request?

float stdlib_base_wrapf( const float v, const float min, const float max );

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Nov 2, 2024
@gururaj1512
Copy link
Contributor Author

Hi @gunjjoshi, could you review this PR? Some checks are failing, need guidance for it.

@gunjjoshi gunjjoshi mentioned this pull request Nov 3, 2024
Merged
1 task
Planeshifter added a commit that referenced this pull request Nov 10, 2024
@gunjjoshi @Planeshifter
feat: add math/base/special/fmodf
7fd112c 
PR-URL: #3059
Ref: #2997
Ref: #3055
Ref: #649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
@gunjjoshi @Planeshifter @aayush0325
feat: add math/base/special/fmodf
8e17660 
PR-URL: stdlib-js#3059
Ref: stdlib-js#2997
Ref: stdlib-js#3055
Ref: stdlib-js#649

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 18, 2024
@kgryte kgryte requested a review from gunjjoshi November 18, 2024 04:25
gunjjoshi
gunjjoshi requested changes Nov 19, 2024
View reviewed changes
@gunjjoshi
Copy link
Member

@gururaj1512 Can you go through the CI failures and make necessary changes in this PR? There are some linting errors and test failures.

@gururaj1512 gururaj1512 mentioned this pull request Dec 8, 2024
Closed
1 task
@gunjjoshi gunjjoshi added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 9, 2024
@gururaj1512
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 16, 2024
@gururaj1512
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 12, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 12, 2025
@gururaj1512
feat: fix test cases
1f0f48e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 12, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/wrapf 240 / 240
+ 100.00 % 		21 / 21
+ 100.00 % 		2 / 2
+ 100.00 % 		240 / 240
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@gururaj1512
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 12, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 12, 2025
@gururaj1512
fix: lint errors
97f09fb 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@gururaj1512 gururaj1512 mentioned this pull request Jan 12, 2025
Open
1 task
@Neerajpathak07 Neerajpathak07 mentioned this pull request Mar 15, 2025
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter

@gunjjoshi gunjjoshi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gururaj1512 @kgryte @gunjjoshi @stdlib-bot @Planeshifter