Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subarray prototype method in fixed-endian-factory #3272

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

DhruvArvindSingh
Copy link
Contributor

@DhruvArvindSingh DhruvArvindSingh commented Nov 26, 2024

Added necessary changes in test ,benchmark and README.md files

Fixes : #3157

This PR adds 'subarray' prototype method in array/fixed-endian-factory.

Updated files(array/fixed-endian-factory):

  • README.md
  • main.js

Added files(array/fixed-endian-factory):

  • benchmark.subarray.length.js
  • benchmark.subarray.js
  • test.subarray.js

Read, understood, and


@stdlib-js/reviewers

Added necessary changes in test ,benchmark and README.md files

Fixes : stdlib-js#3157
@DhruvArvindSingh
Copy link
Contributor Author

Kindly review this PR @kgryte

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 26, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory 1266 / 1521
+ 83.23 %
175 / 189
+ 92.59 %
24 / 34
+ 70.59 %
1266 / 1521
+ 83.23 %

The above coverage report was generated for the changes in this PR.

* bool = out.get( len-1 );
* // returns 2.0
*/
setReadOnly( TypedArray.prototype, 'subarray', function subarray( begin, end) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setReadOnly( TypedArray.prototype, 'subarray', function subarray( begin, end) {
setReadOnly( TypedArray.prototype, 'subarray', function subarray( begin, end ) {

@Planeshifter Planeshifter changed the title feat: adding 'subarray' prototype method in fixed-endian-factory feat: add subarray prototype method in fixed-endian-factory Dec 1, 2024
@Planeshifter Planeshifter added the Needs Review A pull request which needs code review. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review A pull request which needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add subarray method to array/fixed-endian-factory
4 participants