feat: add math/base/special/expf
#3318
Conversation
…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
gunjjoshi
changed the title
math/base/special/expf
|
@vivekmaurya001 Thanks for working on this, CI tests must pass in order to move ahead with this PR. |
…pecial-math-functions
…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions
kgryte
added
the
Needs Changes
…pecial-math-functions
…https://github.com/vivekmaurya001/stdlib into Add-C-implementations-to-base-special-math-functions
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
done changes , waiting for your inputs in this @gunjjoshi ! |
…pecial-math-functions
…pecial-math-functions
…pecial-math-functions
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
gunjjoshi
added
Needs Changes
|
Left an initial review, some changes must be made before landing this PR. |
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
| static float random_uniform( const float min, const float max ) { | ||
| float v = (float)rand() / ( (float)RAND_MAX + 1.0 ); | ||
| return min + ( v*(max-min) ); | ||
| } |
There was a problem hiding this comment.
@vivekmaurya001 We don't need to make a custom function here. You can refer: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/fmodf/examples/c/example.c
There was a problem hiding this comment.
Agree with @gunjjoshi. I will say that we have been creating custom functions in the stats/base/dists/* work, in order to avoid repeated RV generation logic. I am personally fine with either approach. In stats, it is more necessary due to more complex parameterization needs. Here, it is less so.
There was a problem hiding this comment.
i removed the custom function !
vivekmaurya001
deleted the
Add-C-implementations-to-base-special-math-functions
branch
vivekmaurya001
restored the
Add-C-implementations-to-base-special-math-functions
branch
|
ohh , sorry i renamed this branch and it got closed i will do with required changes |
…pecial-math-functions
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Signed-off-by: Vivek maurya <155618190+vivekmaurya001@users.noreply.github.com>
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
|
@gunjjoshi , done all the final changes |
…pecial-math-functions
Signed-off-by: Vivek maurya <155618190+vivekmaurya001@users.noreply.github.com>
Progresses #649
Description
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers