-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add math/base/special/sind
#487
base: develop
Are you sure you want to change the base?
Conversation
lib/node_modules/@stdlib/math/base/special/sind/test/fixtures/julia/all_tests.json
Outdated
Show resolved
Hide resolved
@AlisaLC You mind checking the box above to indicate that you've read the contributing guidelines? In particular, checking this box means agreeing to the licensing terms. |
Done. but if i remember correctly, a few of the tests didn't pass by narrow margins which were normal sin tests but for some reason kernel sin was not as accurate! |
@AlisaLC Thanks! Yeah, kernel sine is sensitive to argument scaling. I'll take a look. |
/stdlib merge |
math/base/special/sind
@gunjjoshi Do you think you'd be up for taking over this PR? |
@kgryte Sure, I'll take this over. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves #32
Description
This pull request:
Related Issues
This pull request:
math/base/special/sind
#32Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers