Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add math/base/special/sind #487

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

AlisaLC
Copy link
Contributor

@AlisaLC AlisaLC commented Feb 5, 2022

Resolves #32

Description

What is the purpose of this pull request?

This pull request:

  • implements sind using kernel sin and kernel cos

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte
Copy link
Member

kgryte commented Feb 15, 2022

@AlisaLC You mind checking the box above to indicate that you've read the contributing guidelines? In particular, checking this box means agreeing to the licensing terms.

@AlisaLC
Copy link
Contributor Author

AlisaLC commented Feb 15, 2022

Done. but if i remember correctly, a few of the tests didn't pass by narrow margins which were normal sin tests but for some reason kernel sin was not as accurate!

@kgryte
Copy link
Member

kgryte commented Feb 15, 2022

@AlisaLC Thanks! Yeah, kernel sine is sensitive to argument scaling. I'll take a look.

@kgryte kgryte added Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Math Issue or pull request specific to math functionality. labels Feb 15, 2022
@kgryte kgryte mentioned this pull request Feb 4, 2023
@kgryte kgryte added Needs Review A pull request which needs code review. Feature Issue or pull request for adding a new feature. labels Feb 23, 2024
@Planeshifter Planeshifter changed the title Add sind implementation feat: add sind implementation Sep 8, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

/stdlib merge

@kgryte kgryte changed the title feat: add sind implementation feat: add math/base/special/sind Nov 18, 2024
@kgryte
Copy link
Member

kgryte commented Nov 18, 2024

@gunjjoshi Do you think you'd be up for taking over this PR?

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Nov 18, 2024
@gunjjoshi
Copy link
Member

@kgryte Sure, I'll take this over.

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/sind 175 / 175
+ 100.00 %
9 / 9
+ 100.00 %
2 / 2
+ 100.00 %
175 / 175
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 25, 2024
@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Base Issue or pull requests related to "low-level" functionality oriented toward library consumers. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add math/base/special/sind
5 participants