Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add stats/incr/nanmmeanabs #5589 #6341

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor: add stats/incr/nanmmeanabs #5589 #6341

wants to merge 2 commits into from

Conversation

Kavyansh-Bagdi
Copy link
Contributor

Resolves #5589.

Description

What is the purpose of this pull request?

This pull request:

  • Adds the package @stdlib/stats/incr/nanmmeanabs, which provides an accumulator function to compute a moving mean of absolute values, ignoring NaN values.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • The implementation follows the established incremental computation patterns within the @stdlib/stats/incr namespace.
  • Unit tests and benchmarks have been added to ensure correctness and performance.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the contributing guidelines.
  • Added appropriate unit tests for the new functionality.
  • Added or updated relevant documentation.

@stdlib-js/reviewers

@Kavyansh-Bagdi
refactor: add stats/incr/nanmmeanabs
fc6b89c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Mar 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 24, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmmeanabs 142 / 142
+ 100.00 % 		7 / 7
+ 100.00 % 		2 / 2
+ 100.00 % 		142 / 142
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@Kavyansh-Bagdi
fix: lint copyright year
7ae7f86 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@Kavyansh-Bagdi
Copy link
Contributor Author

@kgryte Could you please review my PR ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmmeanabs
2 participants
@Kavyansh-Bagdi @stdlib-bot