Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: disable lint rule #6404

Merged
merged 2 commits into from
Mar 27, 2025
Merged

style: disable lint rule #6404

merged 2 commits into from
Mar 27, 2025

Conversation

sahilk45
Copy link
Contributor

Resolves #6384

Description

Resolves C linting failures detected in the automated lint workflow run.

This pull request:

  • Renamed local variable to prevent function name conflict
  • Addressed linting errors to improve code quality

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Fixed variable shadowing in lib/node_modules/@stdlib/math/base/special/maxabs/src/addon.c

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 26, 2025
@sahilk45
Update addon.c
dfe43f6 
Signed-off-by: SAHIL KUMAR <168997976+sahilk45@users.noreply.github.com>
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/maxabs 160 / 160
+ 100.00 % 		5 / 5
+ 100.00 % 		2 / 2
+ 100.00 % 		160 / 160
+ 100.00 %

The above coverage report was generated for the changes in this PR.

@sahilk45 sahilk45 requested a review from anandkaranubc March 27, 2025 12:12
anandkaranubc
anandkaranubc approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@anandkaranubc anandkaranubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@kgryte kgryte added C Issue involves or relates to C. and removed Needs Review A pull request which needs code review. labels Mar 27, 2025
@kgryte kgryte changed the title Fixing C lint error style: disable lint rule Mar 27, 2025
@kgryte kgryte merged commit 8839ab9 into stdlib-js:develop Mar 27, 2025
32 of 33 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 28, 2025
@sahilk45 @sahil20021008
style: disable lint rule
78779cf 
PR-URL: stdlib-js#6404
Closes: stdlib-js#6384
Reviewed-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com>
Signed-off-by: SAHIL KUMAR <168997976+sahilk45@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte

@anandkaranubc anandkaranubc

Assignees
No one assigned
Labels
C Issue involves or relates to C. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix C lint errors
4 participants
@sahilk45 @stdlib-bot @kgryte @anandkaranubc