Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V2 of redjan/fcm-bundle #1747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add V2 of redjan/fcm-bundle #1747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd2c4f
Add V2 of redjan/fcm-bundle
redjanym Jan 27, 2025
a9ae595
Rename ENV var
redjanym Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions redjanym/fcm-bundle/2.0/config/packages/redjan_ym_fcm.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
redjan_ym_fcm:
service_account_file: '%env(resolve:FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH)%'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you don't call it a default service account file in the bundle, env doesn't need it as well.

Suggested change
service_account_file: '%env(resolve:FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH)%'
service_account_file: '%env(resolve:FCM_SERVICE_ACCOUNT_FILE_PATH)%'

11 changes: 11 additions & 0 deletions redjanym/fcm-bundle/2.0/manifest.json
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"bundles": {
"RedjanYm\\FCMBundle\\RedjanYmFCMBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
},
"env": {
"FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH": "YOUR_FCM_SERVICE_ACCOUNT_FILE_ABSOLUTE_PATH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've assumed it's a json from https://github.com/redjanym/FCMBundle/wiki/Installation#step-3-configuration

Suggested change
"FCM_DEFAULT_SERVICE_ACCOUNT_FILE_PATH": "YOUR_FCM_SERVICE_ACCOUNT_FILE_ABSOLUTE_PATH"
"FCM_SERVICE_ACCOUNT_FILE_PATH": "%kernel.project_dir%/path/to/file.json"

}
}