Skip to content
This repository was archived by the owner on Mar 16, 2019. It is now read-only.

fs.asset() function inconsistent between platforms #269

Open
benvium opened this issue Feb 16, 2017 · 1 comment
Open

fs.asset() function inconsistent between platforms #269

benvium opened this issue Feb 16, 2017 · 1 comment

Comments

@benvium
Copy link

benvium commented Feb 16, 2017

On Android, the fs.asset('path/to/file') function returns a path that when used with fs functions, works on files embedded in the APK app bundle, specifically from the app/src/main/assets directory. This works great.
(reference for Java implementation)

On iOS, I expected that fs.asset('path/to/file') would return a path that allows access to files embedded in the IPA app bundle, e.g. ${fs.dirs.MainBundleDir}/path/to/file.
However it actually returns a path that allows access to the camera roll.
(reference in js)

This is easy to work around of course.
It'd be a breaking change to adjust this (perhaps add new function fs.js | cameraRoll(path:string)?

I can send a PR if this is useful.

@wkh237
Copy link
Owner

wkh237 commented Feb 17, 2017

@benvium , thanks for the advice 👍 I'll add this one to 0.11.0 milestone 😄

@wkh237 wkh237 added this to the v0.11.0 milestone Feb 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants