Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake to 3.16 and add OPUS_STATIC_RUNTIME option #335

Closed
wants to merge 1 commit into from

Conversation

Malcolmnixon
Copy link
Contributor

This resolves issue #333 by:

  • Updating CMake to 3.16 as recommended in the issue discussions
  • Adding the OPUS_STATIC_RUNTIME option when using MSVC
  • Updating the CMake CI action to use 3.16

@xnorpx
Copy link
Contributor

xnorpx commented Apr 4, 2024

@jmvalin can you hit approve and run se we can see the CI run.

@xnorpx
Copy link
Contributor

xnorpx commented Apr 4, 2024

@Malcolmnixon I assume you tested to build the static version in your project and verified it worked on a machine without the runtime dlls installed?

@Malcolmnixon
Copy link
Contributor Author

@Malcolmnixon I assume you tested to build the static version in your project and verified it worked on a machine without the runtime dlls installed?

Yes - I confirmed cmake -DOPUS_STATIC_RUNTIME=ON produces a vcxproj with the runtime library configured for static (non-DLL) runtime, and the subsequent build then links correctly with my project.

@xnorpx
Copy link
Contributor

xnorpx commented Apr 5, 2024

@jmvalin this change LGTM but should just run it through CI once before merging.

@jmvalin
Copy link
Member

jmvalin commented Apr 8, 2024

Merged

@jmvalin jmvalin closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants