Skip to content

core(windows): remove code that caused location to be always accessed #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MSOB7YY
Copy link

@MSOB7YY MSOB7YY commented May 1, 2025

while a windows version of the app is running, windows will show that the app is always accessing location, even tho location was never accessed or requested from the app code

im not sure why this block was added in the first place even tho the callback doesn't call any other code, i haven't done much tests but await Permission.location.request() returns PermissionStatus.granted normally

PermissionHandlerWindowsPlugin::PermissionHandlerWindowsPlugin(){
--  m_positionChangedRevoker = geolocator.PositionChanged(winrt::auto_revoke,
--    [this](Geolocator const& geolocator, PositionChangedEventArgs e)
--    {
--    });
}

List at least one fixed issue.

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

@saif-ellafi
Copy link

Oh yes, came to report this! I was scared when my users reported it!

@LucasXu0
Copy link

LucasXu0 commented Jul 8, 2025

What's the reason preventing this PR from getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Windows shows app as constantly using the device's location
3 participants