feat: copy frameworks to Frameworks folder, detect linkers, custom target dirs #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
changed the title
jkelleyrtp
changed the title
|
Seems like error[E0425]: cannot find function `dlsym` in crate `libc`
--> packages\subsecond\subsecond\src\lib.rs:699:15
|
699 | libc::dlsym(libc::RTLD_DEFAULT, c"main".as_ptr() as _) as _
| ^^^^^ not found in `libc`
error[E0425]: cannot find value `RTLD_DEFAULT` in crate `libc`
--> packages\subsecond\subsecond\src\lib.rs:699:27
|
699 | libc::dlsym(libc::RTLD_DEFAULT, c"main".as_ptr() as _) as _
| ^^^^^^^^^^^^ not found in `libc` |
- long paths? - reverting back to original
AnteDeliria
pushed a commit
to AnteDeliria/dioxus
that referenced
this pull request
Jun 2, 2025
…rget dirs (DioxusLabs#4174) * feat: copy frameworks to Frameworks folder * add dylib linking to patching * remove logging * rename __aslr_offset * fix android/linux * support linker flavor * support custom target dirs * custom cargo target dir support * whoops ios * dlsym doesn't exist on windows * look for the right main symbol per platform * distinction between mains * export main on windows * enbable rlib caching * add dx hash * adjust linking warnings * update tui with hotreload state * implement symbol flags * add flags * only run ranlib on darwin * enable lld * paths * add harness test for tls * wip: revert launch mobile * wip * fix fullstack mobile * fix a few bugs - long paths? - reverting back to original * pass-thru fuse-ld args * fix nan in render, fix empty archives * consider existing dep files if archive exists * fmt * drop msrv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4154 by implementing framework linking in our bundle setup.
Fixes #4146
Fixes #4149
Fixes #4159
Fixes #4165
Fixes long paths?
Fixes aarch64-unknown-linux subsecond
Previously we assumed all apps were statically linked into the bundle, but projects like bevy rely on dynamic linking of code, which breaks that assumption. This fix is not just for subsecond, but rather any rust crate that compiles as a dylib, since we weren't distributing those dylibs at all.
This kicks in for both
.sofiles and.dylibs, but I'm unsure how we should handle windows, so I simply left it as a todo. We can't just blindly copy.dllfiles since system frameworks also end in.dll.Anyways, this fixes subsecond + bevy dynamic linking which makes the rebuilds much faster.