Add placeholder closure to MessageAvatarView #848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laevandus
force-pushed
the
feature/message-avatar-view-custom-placeholder
branch
from
d2fd438 to
42994c0
Compare
SDK Size
|
nuno-vieira
reviewed
Jun 2, 2025
Comment on lines
+46
to
+50
| if let image = content.image { | ||
| image | ||
| } else { | ||
| placeholder() | ||
| } |
There was a problem hiding this comment.
I think it is important that we allow changing the placeholder whether the image view failed or is loading as well. By default, it should use the same placeholder, but we should allow providing the different available states.
I guess we can add a loading() and an error() closures, or alternativly, we provide the state to the closure (The state should be our abstraction and not Nuke's state, something like this: let placeholder: (AvatarViewState) -> Placeholder
There was a problem hiding this comment.
Yes, I agree - I think it's easier if we just provide a wrapper of the state, instead of multiple closures.
| Image(uiImage: images.userAvatarPlaceholder2) | ||
| .resizable() | ||
| placeholder() | ||
| .clipShape(Circle()) |
There was a problem hiding this comment.
why do we clip it to circle here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves: IOS-842
🎯 Goal
Allow customising placeholders in
MessageAvatarView📝 Summary
placeholderview builder🛠 Implementation
We use Nuke internally and it has some breaking changes coming when we upgrade it. Therefore, we need to make minimal changes here. Ideally we could provide
placeholderandcontentclosures, but NukeImage is an internal type.🎨 Showcase
Please refer to snapshot tests.
🧪 Manual Testing Notes
N/A
☑️ Contributor Checklist
docs-contentrepo