Skip to content

Overhead of deprecation warnings increased with 500x (linux) and ~10x (mac) vs 1.11 #58326

New issue
New issue
Open
#58355
Open
Overhead of deprecation warnings increased with 500x (linux) and ~10x (mac) vs 1.11#58326
#58355
Labels
deprecationThis change introduces or involves a deprecationperformanceMust go fasterregressionRegression in behavior compared to a previous version
@KristofferC

Description

@KristofferC
KristofferC
opened on May 6, 2025 · edited by KristofferC
Member

Linux:

# 1.12
$  julia +1.12-nightly --depwarn=yes -q
julia> using SpecialFunctions, BenchmarkTools

julia> @btime lgamma(2.0)
┌ Warning: `lgamma(x::Real)` is deprecated, use `(logabsgamma(x))[1]` instead.
│   caller = var"##core#279"() at execution.jl:598
└ @ Core ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:598
  36.587 ms (95 allocations: 12.99 KiB)

#1.11
$  julia +1.11 --depwarn=yes -q
julia> using SpecialFunctions, BenchmarkTools

julia> @btime lgamma(2.0)
┌ Warning: `lgamma(x::Real)` is deprecated, use `(logabsgamma(x))[1]` instead.
│   caller = var"##core#235"() at execution.jl:598
└ @ Main ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:598
  57.840 μs (111 allocations: 12.23 KiB)
0.0

Mac:

# 1.12
❯ julia +1.12-nightly --depwarn=yes -q
julia> using SpecialFunctions, BenchmarkTools

julia> @btime lgamma(2.0)
┌ Warning: `lgamma(x::Real)` is deprecated, use `(logabsgamma(x))[1]` instead.
│   caller = var"##core#279"() at execution.jl:598
└ @ Core ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:598
  660.375 μs (90 allocations: 11.66 KiB)
0.0

# 1.11
❯ julia +1.11 --depwarn=yes -q
julia> using SpecialFunctions, BenchmarkTools

julia> @btime lgamma(2.0)
┌ Warning: `lgamma(x::Real)` is deprecated, use `(logabsgamma(x))[1]` instead.
│   caller = var"##core#235"() at execution.jl:598
└ @ Main ~/.julia/packages/BenchmarkTools/1i1mY/src/execution.jl:598
  69.916 μs (107 allocations: 12.34 KiB)
0.0

This might be the reason that quite a few packages time out on 1.12 PkgEval?

Activity

KristofferC
added
deprecationThis change introduces or involves a deprecation
performanceMust go faster
regressionRegression in behavior compared to a previous version
on May 6, 2025
KristofferC
changed the title [-]Overhead of deprecation warnings increased with ~7x vs 1.11[/-] [+]Overhead of deprecation warnings increased with ~10x vs 1.11[/+] on May 6, 2025
KristofferC
changed the title [-]Overhead of deprecation warnings increased with ~10x vs 1.11[/-] [+]Overhead of deprecation warnings increased with 500x (linxux) and ~10x (mac) vs 1.11[/+] on May 6, 2025
KristofferC
changed the title [-]Overhead of deprecation warnings increased with 500x (linxux) and ~10x (mac) vs 1.11[/-] [+]Overhead of deprecation warnings increased with 500x (linux) and ~10x (mac) vs 1.11[/+] on May 6, 2025
giordano

giordano commented on May 6, 2025

@giordano
giordano
on May 6, 2025
Member

I had seen issues a few months ago: Team-RADDISH/ParticleDA.jl#286 (comment)

gbaraldi

gbaraldi commented on May 6, 2025

@gbaraldi
gbaraldi
on May 6, 2025 · edited by gbaraldi
Member

Debugging fun:
Ok, so talking with
@topolarity we figured out that the reason for the slowdown is that in the backtrace that is taken on every single call to depwarn (this is already bad but 🤷 ) we do some debuginfo lookups, and those lookups are incredibly slow on mac, like multi ms long calls. We seem to have a happy path for JIT code and others (and I thought that our sysimages were supposed to hit this). The reason for the slowdown is that there's a new apply_gr call that takes 10ms to suceed

julia> @btime Base.StackTraces.lookup(bt[1])
  4.300 μs (6 allocations: 448 bytes)
3-element Vector{Base.StackTraces.StackFrame}:
 macro expansion at REPL[30]:13 [inlined]
 macro expansion at logging.jl:401 [inlined]
 _depwarn(msg::Any, funcsym::Any, force::Bool) at REPL[30]:9

julia> @btime Base.StackTraces.lookup(bt[2])
  223.721 ns (4 allocations: 208 bytes)
1-element Vector{Base.StackTraces.StackFrame}:
 _depwarn(msg::Any, funcsym::Any, force::Bool)

julia> @btime Base.StackTraces.lookup(bt[3])
  10.624 ms (5 allocations: 224 bytes)
1-element Vector{Base.StackTraces.StackFrame}:
 apply_gr(::GlobalRef, ::Any, ::Vararg{Any}) at reflection.jl:1278

The slowdown on mac is caused by something different (maybe inference issues due to this being defined early) and redefining it brings the performance back to what it was before) .

topolarity
linked a pull request that will close this issue on May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationThis change introduces or involves a deprecationperformanceMust go fasterregressionRegression in behavior compared to a previous version

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @giordano@KristofferC@gbaraldi

      Issue actions
        Overhead of deprecation warnings increased with 500x (linux) and ~10x (mac) vs 1.11 · Issue #58326 · JuliaLang/julia