Skip to content

Ability to save the Dockerfile created by build_docker_image deployment step #12938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
3 tasks done
discdiver opened this issue Jun 14, 2023 · 2 comments · May be fixed by #17866
Open
3 tasks done

Ability to save the Dockerfile created by build_docker_image deployment step #12938

discdiver opened this issue Jun 14, 2023 · 2 comments · May be fixed by #17866
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers

Comments

@discdiver
Copy link
Contributor

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar request and didn't find it.
  • I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the current behavior

No Dockerfile is persisted.

Describe the proposed behavior

A Dockerfile is persisted.

Example Use

The user could then inspect the Dockerfile to make deployments with Docker more transparent.

The user could also then modify the Dockerfile and specify the modified Dockerfile in prefect.yaml.

Additional context

I talked to @desertaxle about this a bit already.

In my own use and at PACC it was observed that this functionality would be helpful for debugging.
@discdiver discdiver added the enhancement An improvement of an existing feature label Jun 14, 2023
@discdiver discdiver changed the title Ability to save the Dockerfile created by prefect deploy --recipe docker Ability to save the Dockerfile created by prefect init --recipe docker Jun 14, 2023
@serinamarie
Copy link
Contributor

I think if we removed deletion of the Dockerfile at the end of prefect_docker.steps.build_docker_image, the Dockerfile will persist, but the build step will still have dockerfile: auto which would no longer be accurate the next time that the build step was run, as we'd want to use the Dockerfile they have. So we'd want to think about that.

@serinamarie serinamarie transferred this issue from PrefectHQ/prefect Jun 30, 2023
@desertaxle desertaxle transferred this issue from PrefectHQ/prefect-docker Apr 26, 2024
@desertaxle desertaxle changed the title Ability to save the Dockerfile created by prefect init --recipe docker Ability to save the Dockerfile created by build_docker_image deployment step Jul 29, 2024
@desertaxle desertaxle added the good first issue This issue is good for newcomers label Jul 29, 2024
@AliLordLoss
Copy link

Hi, I would like to work on this issue.

@AliLordLoss AliLordLoss linked a pull request Apr 19, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added option to persist auto-generated Dockerfile AliLordLoss/prefect
4 participants
@discdiver @desertaxle @serinamarie @AliLordLoss