add logfire dep group for performance exploration #17860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #17860 will not alter performanceComparing Summary
|
zzstoatzz
added
development
zzstoatzz
changed the title
desertaxle
reviewed
Apr 23, 2025
Comment on lines
11
to
28
| class _LogfireSettings(PrefectBaseSettings): | ||
| """ | ||
| Settings for Logfire tracing | ||
| """ | ||
|
|
||
| model_config: ClassVar[SettingsConfigDict] = build_settings_config( | ||
| ("experiments", "logfire") | ||
| ) | ||
|
|
||
| enabled: bool = Field( | ||
| default=False, | ||
| description="If `True`, enables Logfire tracing. Set to `False` to disable Logfire tracing.", | ||
| ) | ||
|
|
||
| write_token: Optional[str] = Field( | ||
| default=None, | ||
| description="The Logfire write token to use for tracing.", | ||
| ) |
There was a problem hiding this comment.
If logfire isn't going to be installed via normal operation, I don't think we should include these settings as part of our schema. If we want to keep these settings then I think we should add a logfire extra. Otherwise, I think we can use plain environment variables to control logfire.
try to fix type error
desertaxle
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
logfireandpyinstrumentbehind aperfdependency group (not published in project metadata)to use this with
prefect server start, just setthis should have no effect by default