Skip to content

Don't use local @ARGV=...; <> for slurping file contents #1466

@ferki

Description

@ferki
Member

Migrated from rt.cpan.org #98871 (status was 'new')

Requestors:

From srezic@cpan.org (@eserte) on 2014-09-14 13:47:34
:

Rex::Config is using something like

@ARGV = ...; <>

to slurp file contents, and this may happen during compile time (e.g. read_ssh_config is called in import(), so a "use Rex::Config" would trigger this code). Unfortunately this means that a currently active <> loop would break. See cpan-testers/CPAN-Reporter#20 for an issue where this actually happens.

Probably it's safer to use instead

do { open my $fh, $file or die $!; undef $/; <$fh> }

even if it's slightly longer. Or alternatively

use IO::File ();
join '', IO::File->new($file)->getlines;

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @ferki

      Issue actions

        Don't use local @ARGV=...; <> for slurping file contents · Issue #1466 · RexOps/Rex