Skip to content

TransitionablePortal: onClose is called even on button click when controlled #4056

Open
@lainermeister

Description

@lainermeister

Bug Report

Steps

In this sandbox, click Open Portal, then click Close Portal. Check the console.
https://codesandbox.io/s/happy-drake-yly34?file=/example.js

Expected Result

One callback of onClose triggered

CB triggered: Button closed 

Actual Result

Two callbacks of onClose triggered

CB triggered: Button closed 
CB triggered: Portal closed 

Version

"semantic-ui-react": "1.2.1"

Testcase

https://codesandbox.io/s/happy-drake-yly34?file=/example.js

Activity

welcome

welcome commented on Sep 3, 2020

@welcome

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

changed the title [-]TransitionablePortal onClose is called even on button click when controlled[/-] [+]TransitionablePortal: onClose is called even on button click when controlled[/+] on Sep 7, 2020
srid12

srid12 commented on Oct 14, 2020

@srid12

I would like to solve it

linked a pull request that will close this issue on Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @srid12@layershifter@lainermeister

      Issue actions

        TransitionablePortal: onClose is called even on button click when controlled · Issue #4056 · Semantic-Org/Semantic-UI-React