-
-
Notifications
You must be signed in to change notification settings - Fork 47k
Adding doctests in stock_span_problem.py #10540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AasheeshLikePanner
wants to merge
15
commits into
TheAlgorithms:master
Choose a base branch
from
AasheeshLikePanner:StockAndSpan_Doctests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
bda3f0c
Adding doctests in simpson_rule.py
AasheeshLikePanner 2186089
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 50ecc03
Update stock_span_problem.py
AasheeshLikePanner 463d0cb
Merge remote-tracking branch 'origin/StockAndSpan_Doctests' into Stoc…
AasheeshLikePanner c0e2b16
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 76d97c9
Update subset_generation.py
AasheeshLikePanner 3e5a3f4
Merge remote-tracking branch 'origin/StockAndSpan_Doctests' into Stoc…
AasheeshLikePanner 136bf70
Update subset_generation.py
AasheeshLikePanner 8ab4033
Update data_structures/stacks/stock_span_problem.py
AasheeshLikePanner ad99674
Update stock_span_problem.py
AasheeshLikePanner c76afc8
Merge remote-tracking branch 'origin/StockAndSpan_Doctests' into Stoc…
AasheeshLikePanner 6bd76ea
Update data_structures/stacks/stock_span_problem.py
AasheeshLikePanner 6a230a5
Update stock_span_problem.py
AasheeshLikePanner 3ba3cf7
Update stock_span_problem.py
AasheeshLikePanner ec23923
Merge remote-tracking branch 'origin/StockAndSpan_Doctests' into Stoc…
AasheeshLikePanner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you forcing to caller to allocate this memory? Why not do this in the function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AasheeshLikePanner didn't write the code in that way. The code was already like that back when it was first contributed to the repo. The code had the caller allocate the memory because it was directly copied (and thus plagiarized) from the GeeksForGeeks article you linked a few hours ago.