Codes for calculating values of elements in half wave rectifier. #9388
Conversation
algorithms-keeper
bot
added
the
require tests
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
half_wave_rectifier/hwr.py
Outdated
| else: | ||
| return Result("max_load_current ", vm/(rf+rs+rl)) | ||
|
|
||
| def dc_current(im: float) ->tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file half_wave_rectifier/hwr.py, please provide doctest for the function dc_current
half_wave_rectifier/hwr.py
Outdated
| """ | ||
| return Result("Idc ", im*0.318) | ||
|
|
||
| def dc_voltage(vm: float) ->tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file half_wave_rectifier/hwr.py, please provide doctest for the function dc_voltage
half_wave_rectifier/hwr.py
Outdated
| """ | ||
| return Result("Vdc ", 0.318*vm) | ||
|
|
||
| def max_current(vm: float, rl: float) ->tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file half_wave_rectifier/hwr.py, please provide doctest for the function max_current
half_wave_rectifier/hwr.py
Outdated
| else: | ||
| return Result("Max_current_Im ", vm/rl) | ||
|
|
||
| def rms_current(im: float) ->tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file half_wave_rectifier/hwr.py, please provide doctest for the function rms_current
half_wave_rectifier/hwr.py
Outdated
| """ | ||
| return Result("Irms ", im/2) | ||
|
|
||
| def rms_volatge(vm: float) ->tuple: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file half_wave_rectifier/hwr.py, please provide doctest for the function rms_volatge
for more information, see https://pre-commit.ci
Corrected docktest for the functons
algorithms-keeper
bot
removed
require tests
Please change the title of this pull request so it describes what the PR does. |
SpritualCoder
changed the title
Code for calculating various things in half wave rectifier
Describe your change:
I have written a code for calculating various values in a half wave rectifier circuit.
This code include code for the following :
Checklist: