Skip to content

Added shunt capacitor power factor correction #9535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Yosef-6
Copy link

@Yosef-6 Yosef-6 commented Oct 2, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Oct 2, 2023
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 2, 2023
Yosef-6 and others added 2 commits October 2, 2023 14:41
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 2, 2023
@Yosef-6 Yosef-6 closed this Oct 3, 2023
@Yosef-6 Yosef-6 deleted the added-shunt-capacitor-power-factor-correction branch October 3, 2023 20:39
@Yosef-6 Yosef-6 restored the added-shunt-capacitor-power-factor-correction branch October 3, 2023 20:40
@Yosef-6 Yosef-6 reopened this Oct 3, 2023
@Yosef-6 Yosef-6 mentioned this pull request Oct 5, 2023
14 tasks
@rohan472000
Copy link
Contributor

Seems correct but can you don't add L and R also with another function, all 3 in a single class???

@Yosef-6
Copy link
Author

Yosef-6 commented Oct 5, 2023

Ok but Resistors don't affect reactive power inductors and capacitors do
i will add L and C in one class

@rohan472000
Copy link
Contributor

rohan472000 commented Oct 5, 2023

For R, to correct the power factor of a load with an undesired resistance, I think u need to add a parallel shunt resistor, its calculation will involve the real power and resistance.

It's been 2 yrs since I don't touched electrical engineering, so correct me if I goes wrong somewhere.

@Yosef-6
Copy link
Author

Yosef-6 commented Oct 5, 2023

Thats possible sir
but power factor correction is needed without affecting the real power absorbed by the load adding a resistor affects amount of power the load absorbs i haven't seen a use case that uses a resistor to correct power factor
so capacitor is used if load is lagging (inductive)
inductors used when the load is leading (capacitive)
in both cases we must approach the pf to unity by adding the respective element(power factor correction) without altering the real power absorbed by the load
i will create an inductor one and add additional examples and checks

@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 6, 2023
@Yosef-6
Copy link
Author

Yosef-6 commented Oct 6, 2023

For R, to correct the power factor of a load with an undesired resistance, I think u need to add a parallel shunt resistor, its calculation will involve the real power and resistance.

It's been 2 yrs since I don't touched electrical engineering, so correct me if I goes wrong somewhere.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants