Add profiling manager snippets for how-to-capture DAC docs #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
AliceYuan
reviewed
Jul 11, 2025
| // Computations you want to profile | ||
| } | ||
|
|
||
| void sampleRecordSystemTrace() { |
There was a problem hiding this comment.
should we just start the code snippet right before this function?
| super.onCreate(savedInstanceState) | ||
| sampleRecordSystemTrace() | ||
| } | ||
|
|
There was a problem hiding this comment.
same q around just showing the function
| SystemTraceRequestBuilder requestBuilder = new SystemTraceRequestBuilder(); | ||
| requestBuilder.setCancellationSignal(stopSignal); | ||
| requestBuilder.setTag("FOO"); | ||
| requestBuilder.setDurationMs(60000); |
There was a problem hiding this comment.
can we pull this into duration const
| requestBuilder.setCancellationSignal(stopSignal) | ||
| requestBuilder.setTag("FOO") // Caller supplied tag for identification | ||
| requestBuilder.setDurationMs(60000) | ||
| requestBuilder.setBufferFillPolicy(BufferFillPolicy.RING_BUFFER) |
There was a problem hiding this comment.
can we share what the other options are in a comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some snippets required for the upcoming Profiling Manager sections for DAC documents