feat(@schematics/angular): use signal in app component #29109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
alan-agius4
reviewed
Dec 11, 2024
packages/schematics/angular/application/files/module-files/src/app/app.component.ts.template
Outdated
Show resolved
Hide resolved
cexbrayat
force-pushed
the
feat/use-signal
branch
2 times, most recently
from
db677fc to
f849d0c
Compare
This updates the generated `App` component to use a signal for the `title` field.
cexbrayat
force-pushed
the
feat/use-signal
branch
from
f849d0c to
7d34878
Compare
|
@alan-agius4 @dgp1130 PR is ready for review with your feedback |
dgp1130
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Looks good, thanks for updating.
@alan-agius4, is there anything else we need to update, or should this be sufficient?
dgp1130
added
target: minor
alan-agius4
added
action: merge
|
Thanks for the contribution, apologies for the long delay on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Now that signals are recommended, this updates the generated
AppComponentto use a signal for thetitlefield.Does this PR introduce a breaking change?
Other information