add support for backstage-release versions #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rugvip
force-pushed
the
rugvip/new-releases
branch
from
324b83c to
7e5858f
Compare
jhaals
approved these changes
Feb 3, 2022
vinzscam
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this ends up being the simplest way to add support for the new Backstage releases. Been trying it out over in https://github.com/Rugvip/upgrade-helper-diff-next
If the trigger version is <= 0.4, then we consider it to be a create-app version and use that directly. If it's above that, then we'll use the release manifest to look up the create-app version within that release and use that when calling create-app. Apart from the create-app call, the version we end up using everywhere is the one that was used to trigger the workflow. That means we should somewhat smoothly move over from create-app versions to release version, we just get a bit of an awkward bump from 0.4.x up to 0.67.0 or smth like that.
We shouldn't merge this just yet though, it's best if we sync this update with an update to the logic that writes the version to
backstage.json, or we might run into issues.