lookup-create-app-version.js: add retry loop for fetching manifest #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freben
approved these changes
Feb 15, 2022
| manifest = await fetchManifest(inputVersion); | ||
| break; | ||
| } catch (error) { | ||
| console.error( |
There was a problem hiding this comment.
maybe just warn or even info, and saying "retrying" or whatnot? if this is kinda common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manifest may not be available immediately, even though we delay the workflow dispatch until after the manifest repo has been updated. Probably due to delay in the publishing of GitHub pages.
This adds a retry loop that keeps trying to fetch the manifest for a minute before giving up. Seemed simpler to do this rather than setting up credentials and fetching via the API.