19275: spawn_batch creates incorrect relationships when RelationshipTarget is initially empty #19276
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget is initially empty Component hooks may observe an incoherent world state during `World::spawn_batch`, since commands are not flushed between entity insertions. This causing incorrect behavior when multiple entities referenced the same target entity with an initially empty `RelationshipTarget` - each hook would overwrite the previous. This fix ensures that the on_insert hook operates on a consistent view when the `RelationshipTarget` is initially empty, by moving the logic into the command itself.
greeble-dev
added
C-Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #19275
Solution
Component hooks may observe an incoherent world state during
World::spawn_batch, since commands are not flushed between entity insertions. This causing incorrect behavior when multiple entities referenced the same target entity with an initially emptyRelationshipTarget- each hook would overwrite the previous.This fix ensures that the on_insert hook operates on a consistent view when the
RelationshipTargetis initially empty, by moving the logic into the command itself. It may introduce small performance overhead (about 10%) due to additional commands and lookups.Testing
cargo test --workspace