-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Hot patching systems with subsecond #19309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding the documentation on how to setup your system (i.e. download CLI, change linker, etc.) from https://github.com/TheBevyFlock/bevy_simple_subsecond_system :)
Just tried this on Linux with 2 of my existing projects. All I had to do was enable the feature and run with |
Little update: https://github.com/TheBevyFlock/bevy_simple_subsecond_system now supports changing the signatures of systems at runtime. Would be nice if this PR did so too, but I'm also fine with leaving that for a follow-up :) |
The future is now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple notes more than anything else. Really awesome to see this working, this will be a massive selling point of 0.17
Update again: I added an opt-in to rerun hot-patched systems to the prototype. This makes it way nicer to edit UIs live, as it means we can just rerun regular |
Co-authored-by: JMS55 <47158642+JMS55@users.noreply.github.com>
Co-authored-by: Jan Hohenheim <jan@hohenheim.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is in a good spot, once my minor feedback is addressed. Exciting times!
Objective
Solution
Testing