-
-
Notifications
You must be signed in to change notification settings - Fork 919
Add ability to build the server for Windows and run it as a service #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Closes #1104 |
Example service creation command: sc.exe create ntfy start= auto binPath= "YOURPATH\ntfy.exe serve" To use a server.yml file you would create the service like this: sc.exe create ntfy start= auto binPath= "YOURPATH\ntfy.exe serve --config YOURPATH\server.yml"
Example service creation command: sc.exe create ntfy start= auto binPath= "YOURPATH\ntfy.exe serve" To use a server.yml file you would create the service like this: sc.exe create ntfy start= auto binPath= "YOURPATH\ntfy.exe serve --config YOURPATH\server.yml" |
I really don't want to support ntfy server on Windows. It may build, but it will likely not work for all the things. And I have no time to test it. So while this is pretty cool that it works, I must respectfully decline the PR. |
Does it make a difference that I've been successfully running it 24/7 as a Windows service using a lot of the features without any issue? I'm using a reverse-proxy so it has HTTPS and I have webpush working great to the PWA on Android. Here's my active server.yml so we know that at least these settings are functional: base-url: "https://ntfy.xxx.ddnsfree.com" It created all the needed files no problem and runs no problem. I point to the server.yml file by using the --config option. I made the pull request so that the build code mirrors your current code and just the resulting ntfy.exe would include the added server functionality so it wouldn't be any additional work on your end to include it in releases. |
I think that does make a difference;-) I'll just add a disclaimer saying that idk if it's gonna work, and redirect all issues to you hehe |
Can you try to add the Windows CI pipelines, and add it to the docs? That'd help |
I'm sorry, my coding isn't at the level of even knowing where to begin to add that I don't think, but if there's anything else I can do to help this get approved and open up people on Windows being able to run the server please let me know. :) From a build perspective, the only other thing that needs to be installed on Linux for compiling it is: apt install gcc-mingw-w64-x86-64 That's the only difference. I compiled it from Linux using your standard Linux build environment that you build all of the other versions from. |
No description provided.