-
-
Notifications
You must be signed in to change notification settings - Fork 337
Improve visibility of Save button on Settings page #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, I'd love to work on this enhancement. Could you please assign it to me? |
Sure thing @Thirukumaran-T - please check this link for anything contributing related :) Thank you for your interest and please let me know a rough deadline to complete this task. |
Hi @bluewave-labs, Thanks for the details! I’ve started working on the save-button-enhancement as per the contributing guidelines. Could you please let me know if there’s a preferred timeline or deadline you'd like me to follow for completing this task? Looking forward to your guidance! |
It would be great if you can send your pr by next week. Let me know if you need help with the design. |
Yes, I'll send a PR within the week. I could use your help with the design. could you send over some images and details so we can get a better idea of what we can do? |
For now let's leave the snackbar our of this. Can you lower down the shadow a bit, and decrease the height of the bar and let's see how it goes. First I thought it'd left and right align the whole content area (excluding sidebar). Can you check my screenshot as well? |
Yes i'll do like that |
Just wanted to check back here to see if you have any updates :) Bear with me as we are about to make a release, and want this go in after a test. |
@Thirukumaran-T, Since these changes are specific to this page and should not impact the layout of other pages, you can proceed with overriding it here. However, I have a small suggestion: could you reduce the shadow intensity even further? Currently, it's quite prominent and draws immediate attention. A more subtle shadow would be easier on the eyes and less distracting. |
Hii yes i'll reduce the shadow , it seems like overriding the styles from this file not helps, it is responding for the overall global layout |
Great. Seems to be progressing well. Are you going to apply this to all Settings pages in general later on? |
sure, as of now shall i raise PR for the current settings page changes |
Yes. Let's raise a PR, and go from there :) |
Currently, when users make changes on any of the Settings page, the
Save
button is often not visible because it sits at the very bottom of the page. This can cause confusion, as users might think their changes are automatically saved.Proposed solutions:
Make the Save button sticky at the bottom of the viewport so it's always visible while scrolling.
Alternatively (or additionally), show a small banner or notification ("You have unsaved changes") once the user modifies a setting, with a visible Save button inside the banner.
Expected behavior: Users should always be clearly aware that their changes are unsaved and should be able to easily access the Save button at any time without needing to scroll to the bottom.
The text was updated successfully, but these errors were encountered: