Skip to content

Certificate expiry box should be enabled only for HTTPS sites #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gorkem-bwl opened this issue Apr 28, 2025 · 2 comments · Fixed by #2182
Closed

Certificate expiry box should be enabled only for HTTPS sites #2169

gorkem-bwl opened this issue Apr 28, 2025 · 2 comments · Fixed by #2182
Assignees
@peZhmanParsaee
Labels
frontend good first issue Good for newcomers
Milestone
2.1 (Ship of Thes...

Comments

@gorkem-bwl
Copy link
Contributor

Currently certificate expiry box is enabled for all uptime types (docker, ping, port, http). It should be visible only for HTTPS type monitors.
@gorkem-bwl gorkem-bwl added this to the 2.1 (Ship of Theseus) milestone Apr 28, 2025
@peZhmanParsaee
Copy link
Contributor

@gorkem-bwl Hey, can I work on this issue?

@gorkem-bwl
Copy link
Contributor Author

@peZhmanParsaee please go ahead. You can check our document about contributing here to be up to date for requirements: https://github.com/bluewave-labs/Checkmate/blob/develop/CONTRIBUTING.md

Thank you!

@peZhmanParsaee peZhmanParsaee mentioned this issue May 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peZhmanParsaee peZhmanParsaee

Labels
frontend good first issue Good for newcomers
Projects
None yet
Milestone
2.1 (Ship of Theseus)
Development

Successfully merging a pull request may close this issue.

hide certificate expiry box for non-http uptimes peZhmanParsaee/Checkmate
2 participants
@peZhmanParsaee @gorkem-bwl