[SQL-2350] Port Python Table API examples #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidwys
commented
Sep 3, 2024
dawidwys
commented
Sep 3, 2024
dawidwys
commented
Sep 3, 2024
snuyanzin
reviewed
Sep 3, 2024
| from pyflink.table.expressions import row | ||
|
|
||
| CLOUD_PROPERTIES_PATH = os.path.join(os.path.abspath(os.path.dirname(__file__)), | ||
| "../../../config/cloud.properties") |
There was a problem hiding this comment.
should this path be present here or may be replace it with a placeholder?
There was a problem hiding this comment.
btw I was also wondering whether we can have a utility to hide in every example and avoid duplicate code: os.path.join(os.path.abspath(os.path.dirname(__file__)),)
There was a problem hiding this comment.
yes, I tried that, but I failed. I tried putting it in a single module, which I could then import, but I could not manage to make it work. I'll spend a bit more time on that.
There was a problem hiding this comment.
I think I made it work in a way.
twalthr
reviewed
Sep 3, 2024
dawidwys
force-pushed
the
port-examples
branch
from
1152909 to
ec9c9cd
Compare
dawidwys
force-pushed
the
port-examples
branch
from
ec9c9cd to
6b42dff
Compare
twalthr
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.