Port CI/CD example #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twalthr
reviewed
Sep 12, 2024
flink_table_api_python/examples/table/example_08_integration_and_deployment.py
Outdated
Show resolved
Hide resolved
flink_table_api_python/examples/table/example_08_integration_and_deployment.py
Outdated
Show resolved
Hide resolved
| for row in results: | ||
| count = row[0] | ||
| if (count >= 200): | ||
| print("200 elements reached. Stopping...") |
There was a problem hiding this comment.
you have to stop the count_result manually because this is not a try with resource.
There was a problem hiding this comment.
It is a try with resources, I believe. The:
with count_result.collect() as results:
plays the role
There was a problem hiding this comment.
btw, I tested and I see the statement stopped
| print("200 elements reached. Stopping...") | ||
| break | ||
|
|
||
| # By using a closable iterator, the foreground statement will be stopped |
There was a problem hiding this comment.
Suggested change
| # By using a closable iterator, the foreground statement will be stopped | |
| # By using a closable iterator, the foreground statement will be stopped |
Does this apply to Python?
flink_table_api_python/examples/table/example_08_integration_and_deployment.py
Outdated
Show resolved
Hide resolved
flink_table_api_python/examples/table/example_08_integration_and_deployment.py
Outdated
Show resolved
Hide resolved
flink_table_api_python/examples/table/example_08_integration_and_deployment.py
Outdated
Show resolved
Hide resolved
twalthr
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.