Toggle tray between desktop mode and menubar mode #197
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9f5ffa.
Not sure about this, might revert later devhubapp#156 devhubapp#90
Could not reproduce on master version
…Interactions Keeping hidden components rendered to avoid an annoying delay when opening the filters view devhubapp#126
This will probably have some negative effect, e.g. problems on old android devices devhubapp#126 devhubapp@448d096 devhubapp@f3ee8a1
* Fix Linux desktop app crash on boot (devhubapp#150).
As seem at Concurrent Mode conference talk
Like app version and platform
In preparation for a new ColumnOptions component
Bumps [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer) from 3.1.0 to 3.3.2. - [Release notes](https://github.com/webpack-contrib/webpack-bundle-analyzer/releases) - [Changelog](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/webpack-bundle-analyzer@v3.1.0...v3.3.2) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [axios](https://github.com/axios/axios) from 0.18.0 to 0.18.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.18.1/CHANGELOG.md) - [Commits](axios/axios@v0.18.0...v0.18.1) Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot[bot] <support@github.com>
It now shows the wiki page title and the link shows the diff with what was edited
Fix deep link internal handling Handle plan change
Also better handle long titles
|
Thanks for the PR! We shouldn’t remove the tray for everyone, since only one person complained about it. It could be an option where the user decides where they want to show (only tray, only dock or both). |
|
Hi, I removed the source code from GitHub and the pull request was automatically closed by GitHub. Sorry about that. I don't know when I'll re-add the source code, but I'll re-open the pull request then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #196
I am totally new to Electron, so it might be not the best solution to this issue.
From doc, it seems like the only way to remove menubar icon is to call
tray.destroy().Then it would require
getModeMenuItems()returnModeMenuItemsalways.