-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added iOS app QR onboarding integration #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Cool, that looks like not much code to add a whole nice step for the user |
the dark grey text on black background is really hard to see, can that be white? or is it darkmode? |
btw, that QR code is maybe your live dev system? :) |
Indeed 👍
Darkmode the default. But the screenshot seems to be darker than on a physical device.
I did use this QR for testing purposes. But is is not working any more. |
@dgtlmoon , test-application-3-11 failed, is this a flacky test? |
All checks passed. It seemed a flacky test indeed. I’m okay with it being merged into master. |
Co-authored-by: dgtlmoon <leigh@morresi.net>
Co-authored-by: dgtlmoon <leigh@morresi.net>
Co-authored-by: dgtlmoon <leigh@morresi.net>
The in-app texts have been improved, making it clearer for users to understand which steps users need to take. App version 1.0.6 includes dynamic Feature Flags, which can be used to enable features like QR onboarding. It also allows setting the minimum required version of changedetection.io. All of this is aimed at ensuring Changemonitor integrates seamlessly with changedetection.io. Once the pull request is included in the production version, I’ll be able to adjust the Feature Flags, and the functionality will start working automatically. Until then, users can manually add their account. |
Flacky tests again 🤔 |
App version 1.0.6 has landed. Ready when you are 😄 |
Sorry, breaking change in master and i havent had time to catch up :( |
Resolved merge conflicts after |
Hi @dgtlmoon! Could you let me know what the review status of this PR is? The functionality is fully implemented in the iOS app; this is the final step that needs to be taken. |
I’ve built the Changemonitor iOS app that integrates seamlessly with the Changedetection API. To simplify the onboarding process, I’ve added a QR scan feature. By scanning the personal QR code, users can start using the app immediately without needing to enter any login credentials.