Skip to content

Added iOS app QR onboarding integration #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rm335
Copy link
Contributor

@rm335 rm335 commented Apr 10, 2025

I’ve built the Changemonitor iOS app that integrates seamlessly with the Changedetection API. To simplify the onboarding process, I’ve added a QR scan feature. By scanning the personal QR code, users can start using the app immediately without needing to enter any login credentials.

afbeelding
IMG_1067

@dgtlmoon
Copy link
Owner

Cool, that looks like not much code to add a whole nice step for the user

@dgtlmoon
Copy link
Owner

the dark grey text on black background is really hard to see, can that be white? or is it darkmode?

@dgtlmoon
Copy link
Owner

btw, that QR code is maybe your live dev system? :)

@rm335
Copy link
Contributor Author

rm335 commented Apr 10, 2025

Cool, that looks like not much code to add a whole nice step for the user

Indeed 👍

the dark grey text on black background is really hard to see, can that be white? or is it darkmode?

Darkmode the default. But the screenshot seems to be darker than on a physical device.

btw, that QR code is maybe your live dev system? :)

I did use this QR for testing purposes. But is is not working any more.

@rm335
Copy link
Contributor Author

rm335 commented Apr 10, 2025

@dgtlmoon , test-application-3-11 failed, is this a flacky test?

@rm335
Copy link
Contributor Author

rm335 commented Apr 10, 2025

All checks passed. It seemed a flacky test indeed. I’m okay with it being merged into master.

@dgtlmoon dgtlmoon changed the title Added iOS app QR onboarding intergration Added iOS app QR onboarding integration Apr 10, 2025
@rm335
Copy link
Contributor Author

rm335 commented Apr 15, 2025

IMG_1163

The in-app texts have been improved, making it clearer for users to understand which steps users need to take.

App version 1.0.6 includes dynamic Feature Flags, which can be used to enable features like QR onboarding. It also allows setting the minimum required version of changedetection.io.

All of this is aimed at ensuring Changemonitor integrates seamlessly with changedetection.io.

Once the pull request is included in the production version, I’ll be able to adjust the Feature Flags, and the functionality will start working automatically.

Until then, users can manually add their account.

@rm335
Copy link
Contributor Author

rm335 commented Apr 16, 2025

Flacky tests again 🤔

@rm335
Copy link
Contributor Author

rm335 commented Apr 16, 2025

App version 1.0.6 has landed. Ready when you are 😄

@dgtlmoon
Copy link
Owner

Sorry, breaking change in master and i havent had time to catch up :(

@rm335
Copy link
Contributor Author

rm335 commented Apr 19, 2025

Resolved merge conflicts after master was updated.

@rm335
Copy link
Contributor Author

rm335 commented Apr 23, 2025

Hi @dgtlmoon! Could you let me know what the review status of this PR is? The functionality is fully implemented in the iOS app; this is the final step that needs to be taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants