[Rule Tuning] Microsoft Entra ID Exccessive Account Lockouts Detected

[terrancedejesus]

Summary - What I changed

Fixes date in Microsoft Entra ID Exccessive Account Lockouts Detected.

Checklist

• Added a label for the type of pr: bug, enhancement, schema, maintenance, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
• Added the meta:rapid-merge label if planning to merge within 24 hours
• Secret and sensitive material has been managed correctly
• Automated testing was updated or added to match the most common scenarios
• Documentation and comments were added for features that require explanation

Contributor checklist

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?

[github-actions]

Rule: Tuning - Guidelines

These guidelines serve as a reminder set of considerations when tuning an existing rule.

Documentation and Context

• Detailed description of the suggested changes.
• Provide example JSON data or screenshots.
• Provide evidence of reducing benign events mistakenly identified as threats (False Positives).
• Provide evidence of enhancing detection of true threats that were previously missed (False Negatives).
• Provide evidence of optimizing resource consumption and execution time of detection rules (Performance).
• Provide evidence of specific environment factors influencing customized rule tuning (Contextual Tuning).
• Provide evidence of improvements made by modifying sensitivity by changing alert triggering thresholds (Threshold Adjustments).
• Provide evidence of refining rules to better detect deviations from typical behavior (Behavioral Tuning).
• Provide evidence of improvements of adjusting rules based on time-based patterns (Temporal Tuning).
• Provide reasoning of adjusting priority or severity levels of alerts (Severity Tuning).
• Provide evidence of improving quality integrity of our data used by detection rules (Data Quality).
• Ensure the tuning includes necessary updates to the release documentation and versioning.

Rule Metadata Checks

• updated_date matches the date of tuning PR merged.
• min_stack_version should support the widest stack versions.
• name and description should be descriptive and not include typos.
• query should be inclusive, not overly exclusive. Review to ensure the original intent of the rule is maintained.

Testing and Validation

• Validate that the tuned rule's performance is satisfactory and does not negatively impact the stack.
• Ensure that the tuned rule has a low false positive rate.

[approksiu]

LGTM!

[eric-forte-elastic]

I think this is a good approach at the moment. In the future we may want to prefer using an approach using dateutil to parse the date as a more robust method.

[eric-forte-elastic]

This may not be a major concern, but for positive UTC offset timezones it is possible for this unit test to erroneously fail. For instance, we have team members in UTC+5. There will be certain times where the day will be head of UTC time for them.
E.g.

• UTC Time: January 1, 2023, 21:30 (9:30 PM)
• Local Time in UTC+5: January 2, 2023, 02:30 (2:30 AM)
• Local Time in UTC-4: January 1, 2023, 17:30 (5:30 PM)

One way to address this is to start today as defined at UTC+14, but there are other ways too.

Suggested change

	today = datetime.now(timezone.utc).date()
	# Define UTC+14 timezone
	utc_plus_14 = timezone(timedelta(hours=14))
	# Get the current date in UTC+14
	today = datetime.now(utc_plus_14).date()

[Mikaayenson]

IMO I'd probably rewrite this using git commit timestamp. I suspect it would be more reliable. @terrancedejesus if you can just remove the code changes and fix the rule and open an issue, we can try to tackle this similar to how we do in other repos.

[eric-forte-elastic]

IMO I'd probably rewrite this using git commit timestamp. I suspect it would be more reliable. @terrancedejesus if you can just remove the code changes and fix the rule and open an issue, we can try to tackle this similar to how we do in other repos.

I think this makes sense as well 👍 Using this method, the localized date for the commit timestamp can be converted as needed. Also, the future check component of this PR is somewhat fungible. We are really looking for typos, with the obvious typo case being the created date in the future. A git commit timestamp approach also can check for typos on the date looking for if the rule file is new, does the creation/updated date match the commit date. If not, it is likely a typo, etc.