Skip to content

Use stricter type checks #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
microdev1 opened this issue May 11, 2025 · 1 comment · May be fixed by #639
Open

Use stricter type checks #635

microdev1 opened this issue May 11, 2025 · 1 comment · May be fixed by #639

Comments

@microdev1
Copy link

Hi, I've ported Sonner to SolidJS in my fork microdev1/sonner-solidjs and encountered some type ambiguities when using stricter type checks. I was wondering if we could incorporate similar changes upstream—I’d be happy to help implement them.

As a side note, it would be great if SolidJS can be supported in upstream, though that could be discussed in a separate issue.
@emilkowalski
Copy link
Owner

Sure, feel free to submit a PR!

@microdev1 microdev1 linked a pull request May 17, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use stricter type checks and stylistic changes microdev1/sonner-solidjs
2 participants
@emilkowalski @microdev1