Subscribe to state changes earlier, with useLayoutEffect
#624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that `useEffect` calls can emit toasts on the initial render
`useEffect` won't run the callback on the server, so it should always be there?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tjenkinson
commented
Apr 27, 2025
| @@ -1,5 +1,7 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export const safeUseLayoutEffect = typeof window !== 'undefined' ? React.useLayoutEffect : () => {}; | |||
There was a problem hiding this comment.
neither useEffect or useLayoutEffect will run on the server, but useLayoutEffect will log a warning on the server, hence this
tjenkinson
commented
Apr 27, 2025
Comment on lines
+194
to
+201
| React.useEffect(() => { | ||
| if (removed) { | ||
| const timeout = setTimeout(() => { | ||
| removeToastRef.current(toast); | ||
| }, TIME_BEFORE_UNMOUNT); | ||
| return () => clearTimeout(timeout); | ||
| } | ||
| }, [removed]); |
There was a problem hiding this comment.
moved here so that the timer is cleared if component torn down
tjenkinson
commented
Apr 27, 2025
| @@ -690,7 +717,6 @@ const Toaster = React.forwardRef<HTMLElement, ToasterProps>(function Toaster(pro | |||
| } | |||
| } | |||
|
|
|||
| if (typeof window === 'undefined') return; | |||
There was a problem hiding this comment.
shouldn't be needed given inside a useEffect, which won't run on the server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great library!
I wanted to show an error toast using
toast.error()from inside auseLayoutEffect, but it didn't work.This fixes that 🎉
So now providing the
useLayoutEffectis from a component rendered after<Sonner />it should work, and this also means that usinguseEffectanywhere should always work regardless of whether<Sonner />is before or after the component using the hook.Related #168
I also spotted a few race conditions so added some fixes for those in here too
I tried to run the tests locally but
npm run devdoesn't seem to start the web server for some reason, not sure why