Skip to content

[Infra] Stop including AdMob in zip builds #15024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

[Infra] Stop including AdMob in zip builds #15024

merged 3 commits into from
Jun 24, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jun 23, 2025

Fix #14408

  • Verify that AdMob is removed from zip and Carthage builds

XCFramework is removed (see diff)

nickcooke@nickcooke-mac2 firebase (main) % diff <(tree -L 2 /Users/nickcooke/Downloads/Firebase-actions-dir/11_15_0/Firebase) <(tree -L 2 /Users/nickcooke/Downloads/Firebase-release-zip-zip-signed/11_15_0/Firebase)
1c1
< /Users/nickcooke/Downloads/Firebase-actions-dir/11_15_0/Firebase
---
> /Users/nickcooke/Downloads/Firebase-release-zip-zip-signed/11_15_0/Firebase
50a51,52
> ├── FirebaseDynamicLinks
> │   └── FirebaseDynamicLinks.xcframework
107a110,112
> ├── Google-Mobile-Ads-SDK
> │   ├── GoogleMobileAds.xcframework
> │   └── UserMessagingPlatform.xcframework
119c124
< 110 directories, 7 files
---
> 115 directories, 7 files
nickcooke@nickcooke-mac2 firebase (main) % diff /Users/nickcooke/Downloads/Firebase-actions-dir/11_15_0/Firebase/METADATA.md /Users/nickcooke/Downloads/Firebase-release-zip-zip-signed/11_15_0/Firebase/METADATA.md 
61a62,64
> ## FirebaseDynamicLinks (~> FirebaseAnalytics)
> - FirebaseDynamicLinks.xcframework
> 
127a131,134
> ## Google-Mobile-Ads-SDK (~> FirebaseAnalytics)
> - GoogleMobileAds.xcframework
> - UserMessagingPlatform.xcframework
> 
161a169
> FirebaseDynamicLinks                   | 11.15.0
178a187
> Google-Mobile-Ads-SDK                  | 12.6.0
183a193
> GoogleUserMessagingPlatform            | 3.0.0

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after verification

@ncooke3
Copy link
Member Author

ncooke3 commented Jun 24, 2025

Verified. See PR description.

@ncooke3 ncooke3 merged commit ad60650 into main Jun 24, 2025
53 checks passed
@ncooke3 ncooke3 deleted the nc/14408 branch June 24, 2025 15:57
@ncooke3 ncooke3 added this to the Firebase 12 - M167 milestone Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase to stop publishing binary versions of Google Mobile Ads SDK
3 participants