Skip to content

Add getJSON method #3245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jaxx2104
Copy link

@jaxx2104 jaxx2104 commented Jun 21, 2020

Context:

  • There is a method called jsonValue in the iOS and Android SDKs. (FIRConfigValue)
  • The method is not available on the Web, but the Firebase console has a JSON Editor, so it would be nice to have a method to get JSON.

nikuman_Firebase_コンソール

This PR did the following:

  • Add getJSON method ✍️
  • Add unit test ✅

@jaxx2104 jaxx2104 requested a review from erikeldridge as a code owner June 21, 2020 15:36
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jaxx2104
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants