Skip to content

RTBD query get wip #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RTBD query get wip #3786

wants to merge 2 commits into from

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Sep 15, 2020

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2020

💥 No Changeset

Latest commit: a645846

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2020

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (f900417) Head (a872072) Diff
    browser 270 kB 270 kB +61 B (+0.0%)
    esm2017 236 kB 236 kB +35 B (+0.0%)
    main 270 kB 270 kB +61 B (+0.0%)
    module 268 kB 268 kB +61 B (+0.0%)
  • firebase

    Type Base (f900417) Head (a872072) Diff
    firebase-database.js 187 kB 187 kB +58 B (+0.0%)
    firebase.js 830 kB 830 kB +58 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 15, 2020

Size Analysis Report

Affected Products

No changes between base commit (f900417) and head commit (a872072).

Test Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants