Fireperf next #3800
Draft
Fireperf next #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-shaking. (#3513) * Updating the FirebasePerformance Controller and index to support tree-shaking. * Updating error message styling * Moving index.ts to src/index.ts
…into fireperf-next
…in PerformanceController (#3566) * Updating the FirebasePerformance Controller and index to support tree-shaking. * Firebase Performance now registers itself onload to the Firebase App. * Removing side effects using SettingsService and storing dependencies in PerformanceController * Renaming all variables of PerformanceController to 'performanceController' * Moved util functions from settings_service to app_utils * Adding performance to the build under firebase-exp * Removing the namespaceExports when registering Performance * Renaming the init method to _init to indicate it's a private method * Removing FirebasePerformanceInternal and casting directly to PerformanceController to call the _init method
…-shaking. (#3513) * Updating the FirebasePerformance Controller and index to support tree-shaking. * Updating error message styling * Moving index.ts to src/index.ts
…in PerformanceController (#3566) * Updating the FirebasePerformance Controller and index to support tree-shaking. * Firebase Performance now registers itself onload to the Firebase App. * Removing side effects using SettingsService and storing dependencies in PerformanceController * Renaming all variables of PerformanceController to 'performanceController' * Moved util functions from settings_service to app_utils * Adding performance to the build under firebase-exp * Removing the namespaceExports when registering Performance * Renaming the init method to _init to indicate it's a private method * Removing FirebasePerformanceInternal and casting directly to PerformanceController to call the _init method
…js-sdk into fireperf-next
💥 No ChangesetLatest commit: 81d9fbf Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.